[6.0] Smart Search: Removing dependency on CMSObject#43795
Merged
Bodge-IT merged 6 commits intojoomla:6.0-devfrom Feb 12, 2025
Merged
[6.0] Smart Search: Removing dependency on CMSObject#43795Bodge-IT merged 6 commits intojoomla:6.0-devfrom
Bodge-IT merged 6 commits intojoomla:6.0-devfrom
Conversation
Fedik
reviewed
Jul 15, 2024
Fedik
reviewed
Jul 15, 2024
Contributor
|
Which of these methods are regularly used in smart search plugins? Because we'll need to explicitly call out b/c docs in those with docs. |
Member
Author
|
None. The state object normally is only used internally from Smart Search. We've not been using the CMSObject stuff for some time already, at least since 3.10. It's just that no one changed it to a stdClass in time for a major release so far. |
Member
|
Can you document this change in the manual? |
Hackwar
added
Feature
b/c break
4 tasks
Contributor
|
I have tested this item ✅ successfully on fe77bce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795. |
Contributor
|
I have tested this item ✅ successfully on 80e60dc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43795. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
CMSObjectclass has been deprecated for a long time and for 6.0, we want to remove it as much as possible. This PR removes it from Smart Search.Testing Instructions
Apply the PR and run the indexer, look at statistics and search in the frontend and see, that everything still works as expected.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Documentation for removal of CMSObject from core code Manual#380
No documentation changes for manual.joomla.org needed